Quantcast
Channel: PowerShell.com – PowerShell Scripts, Tips, Forums, and Resources
Viewing all articles
Browse latest Browse all 6937

Code enchancment

$
0
0

Hi All,

I need assistance in enchancement below code and make it into function. 

here is script below

IPch = test-connection command is used and it will capture the ping status

$ip = ip address depending on last octlet printer name should be decided as shown below code. I'm using forms to capture output in different forms so depending on ping status it will be sent to respective form as "Printer No."

Please let me know better way of writing below because i need to write whole code twice in my script.

if ($ipch -eq "True")

{

       if ($ip -like "*.225")

      {

         $combobox1ipadd.Items.Add("Printer 6")

      }

        elseif ($ip -like "*.226")

        {

            $combobox1ipadd.Items.Add("Printer 5")

         }

           elseif ($ip -like "*.227")

        {

         $combobox1ipadd.Items.Add("Printer 4")

        }

       elseif (ip -like "*.228")

        {

      $combobox1ipadd.Items.Add("Printer 3")

       }

      elseif ($ip -like "*.229")

       {

        $combobox1ipadd.Items.Add("Printer 2")

        }

       elseif ($ip -like "*.230")

       {

        $combobox1ipadd.Items.Add("Printer 1")

        }

     elseif ($ip -like "*.231")

  {

      $combobox1ipadd.Items.Add("Printer 1")

       }

      elseif ($ip -like "*.232")

        {

     $combobox1ipadd.Items.Add("Printer 2")

       }

     elseif ($ip -like "*.233")

      {

     $combobox1ipadd.Items.Add("Printer 3")

      }

    elseif ($ip -like "*.234")

     {

     $combobox1ipadd.Items.Add("Printer 4")

     }

  }

Else

{

if ($ip -like "*.225")

{

$comboboxipadd.Items.Add("Printer 6")

}

elseif ($ip -like "*.226")

{

$comboboxipadd.Items.Add("Printer 5")

}

elseif ($ip -like "*.227")

{

$comboboxipadd.Items.Add("Printer 4")

}

elseif ($ip -like "*.228")

{

$comboboxipadd.Items.Add("Printer 3")

}

elseif ($ip -like "*.229")

{

$comboboxipadd.Items.Add("Printer 2")

}

elseif ($ip -like "*.230")

{

$comboboxipadd.Items.Add("Printer 1")

}

elseif ($ip -like "*.231")

{

$comboboxipadd.Items.Add("Printer 1")

}

elseif ($ip -like "*.232")

{

$comboboxipadd.Items.Add("Printer 2")

}

elseif ($ip -like "*.233")

{

$comboboxipadd.Items.Add("Printer 3")

}

elseif ($ip -like "*.234")

{

$comboboxipadd.Items.Add("Printer 4")

}

}

 

Thanks in advance


Viewing all articles
Browse latest Browse all 6937

Trending Articles